Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

railsbp/rails-bestpractices.com

Edit Repository
Build
48
Branch
master
Commit
685df16
Duration
14 secs
Finished
about 1 year ago
Message
Merge branch 'hotfix/dalli_with_passenger' into develop
Rebuild

Analyze Result

Warning count: 55

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/controllers/tags_controller.rb 2 move model logic into model (@children use_count > 4) ed33c998 Richard Huang
    app/cells/vote_cell.rb 2,8,17 use before_filter for show,up,down 72606729 Richard Huang
    app/cells/sidebar_cell.rb 38,42,56,60 use before_filter for login,services,posts_navigation,blog_rss e053479c Richard Huang
    app/views/kaminari/_paginator.html.haml 13 move code into model (page use_count > 2) d08855f4 Richard Huang
    db/migrate/20110927115641_add_cached_tag_list_to_questions.rb 4 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20110927115641_add_cached_tag_list_to_questions.rb 5 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20110927115641_add_cached_tag_list_to_questions.rb 6 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20100727124152_add_counter_cache_to_users.rb 8 use say with time in migrations bc72f0e0 Richard Huang
    db/migrate/20110511145447_create_post_bodies.rb 10 use say with time in migrations ac7d25e8 Richard Huang
    db/migrate/20110511145447_create_post_bodies.rb 18 use say with time in migrations ac7d25e8 Richard Huang
    db/migrate/20100726144246_add_implemented_to_posts.rb 5 use say with time in migrations 4b3979be Richard Huang
    db/migrate/20110927114637_add_cached_tag_list_to_posts.rb 4 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20110927114637_add_cached_tag_list_to_posts.rb 5 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20110927114637_add_cached_tag_list_to_posts.rb 6 use say with time in migrations a9b0384d Richard Huang
    db/migrate/20100807150111_remove_comments_from_implementations.rb 4 use say with time in migrations b2e34578 Richard Huang
    db/migrate/20110620144449_create_answer_bodies.rb 10 use say with time in migrations 1a232dd1 Richard Huang
    db/migrate/20110620144449_create_answer_bodies.rb 18 use say with time in migrations 1a232dd1 Richard Huang
    db/migrate/20110627151243_create_question_bodies.rb 10 use say with time in migrations c3972a37 Richard Huang
    db/migrate/20110627151243_create_question_bodies.rb 18 use say with time in migrations c3972a37 Richard Huang
    db/migrate/20100801071356_change_votes_to_polymorphic.rb 6 use say with time in migrations 930cc087 Richard Huang
    app/mailers/notification_mailer.rb 36 use multipart/alternative as content_type of email a426b25c Richard Huang
    app/helpers/application_helper.rb 1 remove empty helpers 0a20bef9 Richard Huang
    config/routes.rb 8 restrict auto-generated routes authentications (:only => [:create, :destroy, :index]) 500ad42e Richard Huang
    config/routes.rb 12 restrict auto-generated routes posts (:only => [:show, :new, :create, :edit, :update, :index]) ae4a6e8a Richard Huang
    config/routes.rb 19 restrict auto-generated routes questions (:only => [:show, :new, :create, :edit, :update, :index]) 6e3666e8 Richard Huang
    config/routes.rb 20 restrict auto-generated routes questions/answers (:only => [:create, :update]) 6e3666e8 Richard Huang
    config/routes.rb 24 restrict auto-generated routes answers (:only => [:create, :update]) 47aa14f2 Richard Huang
    config/routes.rb 37 restrict auto-generated routes jobs (:only => [:show, :new, :create, :edit, :update, :index]) a2dce5c1 Richard Huang
    app/models/job.rb 44 remove unused methods (Job#job_type_names) e2abac4b Richard Huang
    app/models/question.rb 30 remove unused methods (Question#not_answered) 0d6d7610 Richard Huang
    app/controllers/users_controller.rb 40 remove unused methods (UsersController#build_resource) 500ad42e Richard Huang
    app/models/blog_post.rb 14 protect mass assignment 94d2514a Richard Huang
    app/models/job.rb 24 protect mass assignment bdee07ec Richard Huang
    app/models/sponsor_track.rb 11 protect mass assignment bccf309d Richard Huang
    app/models/notifier_observer.rb 1 protect mass assignment e1996dcc Richard Huang
    app/models/post.rb 18 protect mass assignment e99f07ca Richard Huang
    app/models/comment.rb 16 protect mass assignment 575a908b Richard Huang
    app/models/notification_setting.rb 13 protect mass assignment 856bc83b Richard Huang
    app/models/post_body.rb 13 protect mass assignment ac7d25e8 Richard Huang
    app/models/authentication.rb 15 protect mass assignment 500ad42e Richard Huang
    app/models/answer.rb 14 protect mass assignment 930cc087 Richard Huang
    app/models/answer_body.rb 13 protect mass assignment 1a232dd1 Richard Huang
    app/models/job_partner.rb 12 protect mass assignment 4f383a5f Richard Huang
    app/models/notification.rb 14 protect mass assignment e1996dcc Richard Huang
    app/models/sponsor.rb 14 protect mass assignment bccf309d Richard Huang
    app/models/vote.rb 14 protect mass assignment 36f65ea0 Richard Huang
    app/models/job_type.rb 11 protect mass assignment bdee07ec Richard Huang
    app/models/question_body.rb 13 protect mass assignment c3972a37 Richard Huang
    app/models/question.rb 16 protect mass assignment 930cc087 Richard Huang
    app/models/job_job_type.rb 12 protect mass assignment bdee07ec Richard Huang
    app/models/page.rb 12 protect mass assignment 21c401dc Richard Huang
    app/models/ability.rb 1 protect mass assignment f4ec75bd Richard Huang
    config/initializers/formtastic.rb 83 remove trailing whitespace bc389023 Richard Huang
    lib/tasks/cucumber.rake 2 remove trailing whitespace ^6e95c37 Richard Huang
    lib/tasks/backup.rake 2 remove trailing whitespace ef01e997 Richard Huang