Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

bluehotdog/codenews

Edit Repository
Build
2
Branch
master
Commit
a57d852
Duration
2 secs
Finished
about 1 year ago
Message
fixing some stuff
Rebuild

Analyze Result

Warning count: 28

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/controllers/vote_controller.rb 3 move model logic into model (Vote use_count > 4) c7e31c29 Amir Friedman
    app/views/entries/index.html.haml 16 law of demeter e57c5bf3 David Elentok
    db/schema.rb 16 always add db index (authorizations => [user_id]) 0d9a9e72 Amir Friedman
    db/schema.rb 24 always add db index (entries => [user_id]) 2fc380c0 David Elentok
    db/schema.rb 47 always add db index (votes => [user_id]) 254a6426 Amir Friedman
    db/schema.rb 47 always add db index (votes => [entry_id]) 254a6426 Amir Friedman
    app/views/entries/_form.html.haml 1 replace instance variable with local variable 2fc380c0 David Elentok
    app/views/entries/_form.html.haml 2 replace instance variable with local variable 2fc380c0 David Elentok
    app/views/entries/_form.html.haml 4 replace instance variable with local variable 2fc380c0 David Elentok
    app/views/entries/_form.html.haml 6 replace instance variable with local variable 2fc380c0 David Elentok
    app/controllers/entries_controller.rb 44 simplify render in controllers 2fc380c0 David Elentok
    app/helpers/sessions_helper.rb 1 remove empty helpers faa565be Amir Friedman
    app/helpers/entries_helper.rb 1 remove empty helpers 2fc380c0 David Elentok
    app/helpers/vote_helper.rb 1 remove empty helpers 03013b89 Amir Friedman
    app/helpers/application_helper.rb 1 remove empty helpers 8d00f8a4 BlueHotDog
    config/routes.rb 8 restrict auto-generated routes entries (:only => [:show, :create, :index]) 2fc380c0 David Elentok
    app/controllers/vote_controller.rb 29 remove unused methods (VoteController#check_if_user_logged_in) c7e31c29 Amir Friedman
    app/views/entries/index.html.haml 17 not use time_ago_in_words e57c5bf3 David Elentok
    app/models/user.rb 1 protect mass assignment 0d9a9e72 Amir Friedman
    app/models/authorization.rb 1 protect mass assignment 0d9a9e72 Amir Friedman
    app/models/entry.rb 1 protect mass assignment 2fc380c0 David Elentok
    app/models/vote.rb 1 protect mass assignment 254a6426 Amir Friedman
    app/controllers/sessions_controller.rb 7 remove trailing whitespace faa565be Amir Friedman
    app/controllers/vote_controller.rb 27 remove trailing whitespace c7e31c29 Amir Friedman
    app/models/user.rb 2 remove tab, use spaces instead 0d9a9e72 Amir Friedman
    app/models/vote.rb 2 remove tab, use spaces instead c7e31c29 Amir Friedman
    app/controllers/sessions_controller.rb 5 remove tab, use spaces instead faa565be Amir Friedman
    app/controllers/vote_controller.rb 2 remove tab, use spaces instead c7e31c29 Amir Friedman