Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

saberma/shopqi

Edit Repository
Build
149
Branch
master
Commit
33b78f1
Duration
69 secs
Finished
about 1 month ago
Message
remove therubyracer, just use node.js
Rebuild

Analyze Result

Warning count: 188

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/controllers/admin/emails_controller.rb 22 use model association (for subscribe) cfc9fd54 liwh
    app/controllers/admin/users_controller.rb 22 replace complex creation with factory method (user attribute_assignment_count > 2) e12199d1 liwh
    app/controllers/wiki/wiki_pages_controller.rb 95 move model logic into model (v use_count > 4) 7f097dea liwh
    app/controllers/theme/themes_controller.rb 95 move model logic into model (themes use_count > 4) 66f3a20d saberma
    app/controllers/shop/contact_controller.rb 6 move model logic into model (contact use_count > 4) 995134ee saberma
    app/controllers/shop/collections_controller.rb 38 move model logic into model (collection use_count > 4) 138b9422 saberma
    app/controllers/shop/sessions_controller.rb 24 move model logic into model (cart use_count > 4) b2fe494f liwh
    app/controllers/shop/order_controller.rb 65 move model logic into model (order use_count > 4) 28160d8a saberma
    app/controllers/shop/order_controller.rb 99 move model logic into model (notification use_count > 4) 5139aeff saberma
    app/controllers/shop/order_controller.rb 99 move model logic into model (@order use_count > 4) 5139aeff saberma
    app/controllers/shop/order_controller.rb 110 move model logic into model (pay_return use_count > 4) 5139aeff saberma
    app/controllers/shop/order_controller.rb 125 move model logic into model (@order use_count > 4) 5139aeff saberma
    app/controllers/shop/app_controller.rb 30 move model logic into model (request use_count > 4) 01a361d3 saberma
    app/controllers/admin/orders_controller.rb 33 move model logic into model (orders use_count > 4) 84a29f92 saberma
    app/controllers/admin/emails_controller.rb 22 move model logic into model (subscribe use_count > 4) cfc9fd54 liwh
    app/controllers/admin/emails_controller.rb 56 move model logic into model (order use_count > 4) c52af6cc saberma
    app/controllers/admin/emails_controller.rb 56 move model logic into model (shop use_count > 4) c52af6cc saberma
    app/controllers/admin/emails_controller.rb 56 move model logic into model (address use_count > 4) c52af6cc saberma
    app/controllers/admin/assets_controller.rb 23 move model logic into model (max_width use_count > 4) 4e6f060f saberma
    app/controllers/admin/assets_controller.rb 23 move model logic into model (max_height use_count > 4) 4e6f060f saberma
    app/controllers/admin/customers_controller.rb 62 move model logic into model (customers use_count > 4) d29d4582 saberma
    app/controllers/admin/customers_controller.rb 62 move model logic into model ( use_count > 4) d29d4582 saberma
    app/controllers/admin/sessions_controller.rb 16 move model logic into model (request use_count > 4) 124770db liwh
    app/controllers/admin/products_controller.rb 102 move model logic into model (new_product use_count > 4) bf4e33ca saberma
    app/controllers/admin/products_controller.rb 102 move model logic into model (product use_count > 4) bf4e33ca saberma
    app/controllers/admin/shop_theme_settings_controller.rb 15 move model logic into model (preset use_count > 4) ed59322c saberma
    app/controllers/admin/app_controller.rb 13 move model logic into model (resource_code use_count > 4) 3f2a70ae liwh
    app/controllers/admin/app_controller.rb 13 move model logic into model (controller_name use_count > 4) 3f2a70ae liwh
    app/controllers/admin/app_controller.rb 44 move model logic into model (request use_count > 4) ad3b7a04 liwh
    app/controllers/admin/themes_controller.rb 20 move model logic into model (shop use_count > 4) 1bc6e2ad saberma
    app/controllers/admin/themes_controller.rb 20 move model logic into model (name use_count > 4) 1bc6e2ad saberma
    app/controllers/shopqi/registrations_controller.rb 21 move model logic into model ( use_count > 4) 5e46a763 saberma
    app/controllers/shopqi/registrations_controller.rb 21 move model logic into model (resource use_count > 4) 5e46a763 saberma
    config/routes.rb 207 overuse route customizations (customize_count > 3) d55c5f03 saberma
    config/routes.rb 238 overuse route customizations (customize_count > 3) d55c5f03 saberma
    config/routes.rb 291 overuse route customizations (customize_count > 3) d55c5f03 saberma
    config/routes.rb 345 overuse route customizations (customize_count > 3) fad935ff saberma
    app/controllers/shop/articles_controller.rb 18 law of demeter 9887623f saberma
    app/controllers/shop/articles_controller.rb 20 law of demeter 097ef119 liwh
    app/controllers/shop/order_controller.rb 102 law of demeter f65edf00 saberma
    app/controllers/shop/order_controller.rb 102 law of demeter f65edf00 saberma
    app/controllers/shop/order_controller.rb 129 law of demeter f65edf00 saberma
    app/controllers/shop/order_controller.rb 129 law of demeter f65edf00 saberma
    app/controllers/admin/emails_controller.rb 77 law of demeter c52af6cc saberma
    app/liquids/form.rb 108 law of demeter 0d719e8d saberma
    app/liquids/article_drop.rb 20 law of demeter 62f3f80c saberma
    app/liquids/order_drop.rb 43 law of demeter bc728033 liwh
    app/views/shop/order/new.html.haml 82 law of demeter f07e4542 saberma
    app/views/shop/order/new.html.haml 83 law of demeter f07e4542 saberma
    app/views/shop/order/show.html.haml 21 law of demeter aec7b013 liwh
    app/views/shop/order/show.html.haml 22 law of demeter aec7b013 liwh
    app/views/shop/order/show.html.haml 32 law of demeter da039e0d saberma
    app/views/admin/articles/_articles.html.haml 10 law of demeter 211b41d6 liwh
    db/migrate/20120303031526_drop_countries.rb 69 isolate seed data 8e3f7deb saberma
    db/schema.rb 31 always add db index (activities => [user_id]) 23f95558 liwh
    db/schema.rb 31 always add db index (activities => [shop_id]) 23f95558 liwh
    db/schema.rb 59 always add db index (api_clients => [shop_id]) 1139fd3e liwh
    db/schema.rb 69 always add db index (articles => [shop_id]) 211b41d6 liwh
    db/schema.rb 69 always add db index (articles => [user_id]) 211b41d6 liwh
    db/schema.rb 109 always add db index (carts => [customer_id]) 79504b10 saberma
    db/schema.rb 123 always add db index (comments => [shop_id]) 211b41d6 liwh
    db/schema.rb 136 always add db index (consumptions => [shop_id]) 353a38d3 liwh
    db/schema.rb 147 always add db index (custom_collection_products => [product_id]) 90316db7 saberma
    db/schema.rb 240 always add db index (discounts => [shop_id]) 8d1eb33e saberma
    db/schema.rb 249 always add db index (emails => [shop_id]) 2bb058be liwh
    db/schema.rb 260 always add db index (kindeditors => [shop_id]) 97b2c202 liwh
    db/schema.rb 331 always add db index (order_discounts => [order_id]) 8d1eb33e saberma
    db/schema.rb 364 always add db index (order_line_items => [product_variant_id]) 8a21243e saberma
    db/schema.rb 364 always add db index (order_line_items => [product_id]) 8a21243e saberma
    db/schema.rb 408 always add db index (orders => [payment_id]) 79504b10 saberma
    db/schema.rb 449 always add db index (payments => [shop_id]) 895706ee liwh
    db/schema.rb 500 always add db index (product_variants => [shop_id]) 2ab91b76 saberma
    db/schema.rb 611 always add db index (shop_themes => [theme_id]) 840e2094 saberma
    db/schema.rb 652 always add db index (smart_collection_products => [product_id]) a8a6e83d saberma
    db/schema.rb 686 always add db index (subscribes => [shop_id]) 109f8278 liwh
    db/schema.rb 686 always add db index (subscribes => [user_id]) 109f8278 liwh
    db/schema.rb 760 always add db index (webhooks => [application_id]) d7822910 saberma
    db/schema.rb 760 always add db index (webhooks => [shop_id]) d7822910 saberma
    app/controllers/wiki/wiki_pages_controller.rb 34,54,95,114 use before_filter for edit,compare_versions,history,revert ddb71517 liwh
    app/views/wiki/wiki_pages/_form.html.haml 2 replace instance variable with local variable 12b89cd5 liwh
    app/views/wiki/wiki_pages/_form.html.haml 4 replace instance variable with local variable 5797d401 liwh
    app/views/wiki/wiki_pages/_form.html.haml 6 replace instance variable with local variable 5797d401 liwh
    app/views/wiki/wiki_pages/_form.html.haml 8 replace instance variable with local variable 12b89cd5 liwh
    app/views/wiki/wiki_pages/_form.html.haml 10 replace instance variable with local variable 12b89cd5 liwh
    app/views/wiki/wiki_pages/_form.html.haml 11 replace instance variable with local variable 5797d401 liwh
    app/views/wiki/wiki_pages/_form.html.haml 12 replace instance variable with local variable 5797d401 liwh
    app/views/admin/home/guide/_launch.html.haml 3 replace instance variable with local variable 659f67be saberma
    app/views/admin/home/guide/_add_content.html.haml 6 replace instance variable with local variable 95271d4f saberma
    app/views/admin/home/guide/_add_content.html.haml 14 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_add_content.html.haml 14 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_customize_theme.html.haml 6 replace instance variable with local variable 7172c5e9 saberma
    app/views/admin/home/guide/_customize_theme.html.haml 13 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_customize_theme.html.haml 13 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_setup_shipping.html.haml 6 replace instance variable with local variable 07ebd436 saberma
    app/views/admin/home/guide/_setup_shipping.html.haml 13 replace instance variable with local variable 07ebd436 saberma
    app/views/admin/home/guide/_setup_shipping.html.haml 13 replace instance variable with local variable 07ebd436 saberma
    app/views/admin/home/guide/_setup_domain.html.haml 6 replace instance variable with local variable c5b656aa saberma
    app/views/admin/home/guide/_setup_domain.html.haml 13 replace instance variable with local variable c5b656aa saberma
    app/views/admin/home/guide/_setup_domain.html.haml 13 replace instance variable with local variable c5b656aa saberma
    app/views/admin/home/guide/_setup_payment_gateway.html.haml 6 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_setup_payment_gateway.html.haml 12 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_setup_payment_gateway.html.haml 12 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_add_product.html.haml 3 replace instance variable with local variable 7172c5e9 saberma
    app/views/admin/home/guide/_add_product.html.haml 10 replace instance variable with local variable defb3d8e saberma
    app/views/admin/home/guide/_add_product.html.haml 10 replace instance variable with local variable defb3d8e saberma
    app/views/shopqi/home/_sidebar.html.haml 2 replace instance variable with local variable 2b9a8704 saberma
    app/views/shopqi/home/_sidebar.html.haml 3 replace instance variable with local variable 2b9a8704 saberma
    app/views/shopqi/home/_sidebar.html.haml 7 replace instance variable with local variable 2b9a8704 saberma
    app/views/shopqi/home/_sidebar.html.haml 8 replace instance variable with local variable 2b9a8704 saberma
    app/views/shopqi/home/_sidebar.html.haml 18 replace instance variable with local variable 2b9a8704 saberma
    db/migrate/20120530122404_create_doorkeeper_tables.rb 16 use say with time in migrations 1bc6e2ad saberma
    app/models/order.rb 72 use query attribute (payment.name?) 34e476e4 saberma
    app/views/shop/shops/password.html.haml 47 use query attribute (shop.password_message?) 7ce5a404 saberma
    app/views/admin/emails/index.html.haml 25 simplify render in views 735186fe liwh
    app/views/admin/products/new.html.haml 130 simplify render in views ad3e2b31 saberma
    app/views/admin/products/show.html.haml 40 simplify render in views d5f2947c liwh
    app/views/admin/products/show.html.haml 217 simplify render in views 8158f20a saberma
    app/views/admin/home/dashboard.html.haml 49 simplify render in views 23f95558 liwh
    app/views/admin/home/dashboard.html.haml 97 simplify render in views 2bb058be liwh
    app/views/admin/account/index.html.haml 6 simplify render in views 4abaf771 liwh
    app/views/admin/account/index.html.haml 8 simplify render in views d9319d38 liwh
    app/views/admin/articles/new.html.haml 20 simplify render in views 211b41d6 liwh
    app/views/admin/articles/show.html.haml 20 simplify render in views 211b41d6 liwh
    app/views/admin/articles/show.html.haml 35 simplify render in views 211b41d6 liwh
    app/views/admin/articles/show.html.haml 36 simplify render in views 211b41d6 liwh
    app/views/admin/articles/_articles.html.haml 13 simplify render in views e4c0bc5d liwh
    app/views/admin/smart_collections/new.html.haml 23 simplify render in views 0fb53053 saberma
    app/views/admin/smart_collections/show.html.haml 49 simplify render in views 0fb53053 saberma
    app/views/admin/smart_collections/show.html.haml 66 simplify render in views 974b07da liwh
    app/views/admin/comments/index.html.haml 51 simplify render in views f938c806 liwh
    app/views/admin/payments/index.html.haml 28 simplify render in views 33cab112 liwh
    app/views/admin/payments/index.html.haml 83 simplify render in views f63983ac liwh
    app/controllers/wiki/wiki_pages_controller.rb 61 simplify render in controllers 7f097dea liwh
    app/controllers/wiki/wiki_pages_controller.rb 128 simplify render in controllers 1eecf750 liwh
    app/controllers/wiki/wiki_pages_controller.rb 158 simplify render in controllers b86784ce liwh
    app/controllers/shop/order_controller.rb 141 simplify render in controllers 5139aeff saberma
    app/controllers/admin/smart_collections_controller.rb 24 simplify render in controllers 86c439eb saberma
    app/controllers/admin/smart_collections_controller.rb 43 simplify render in controllers a8a6e83d saberma
    app/controllers/admin/articles_controller.rb 20 simplify render in controllers 5cbceb07 liwh
    app/controllers/admin/articles_controller.rb 30 simplify render in controllers 211b41d6 liwh
    app/controllers/admin/orders_controller.rb 34 simplify render in controllers 643f9c01 saberma
    app/controllers/admin/emails_controller.rb 29 simplify render in controllers aa634eaa liwh
    app/controllers/admin/customers_controller.rb 38 simplify render in controllers d8220818 saberma
    app/controllers/admin/customers_controller.rb 50 simplify render in controllers 44dc43f0 saberma
    app/controllers/admin/products_controller.rb 62 simplify render in controllers 78671f6c saberma
    app/controllers/admin/products_controller.rb 117 simplify render in controllers 8158f20a saberma
    app/controllers/admin/weight_based_shipping_rates_controller.rb 24 simplify render in controllers 3e902b79 liwh
    app/controllers/admin/custom_collections_controller.rb 22 simplify render in controllers 86c439eb saberma
    app/controllers/admin/custom_collections_controller.rb 41 simplify render in controllers 90316db7 saberma
    app/controllers/admin/price_based_shipping_rates_controller.rb 24 simplify render in controllers 3e902b79 liwh
    app/controllers/admin/pages_controller.rb 19 simplify render in controllers f5c839f0 liwh
    app/controllers/admin/pages_controller.rb 28 simplify render in controllers 1666c334 saberma
    app/controllers/admin/pages_controller.rb 35 simplify render in controllers 29645af0 saberma
    app/controllers/admin/blogs_controller.rb 28 simplify render in controllers 211b41d6 liwh
    app/controllers/admin/blogs_controller.rb 37 simplify render in controllers 211b41d6 liwh
    app/controllers/admin/blogs_controller.rb 45 simplify render in controllers 29645af0 saberma
    app/controllers/admin/users_controller.rb 18 simplify render in controllers e12199d1 liwh
    app/controllers/shopqi/registrations_controller.rb 18 simplify render in controllers 57470ecd saberma
    app/models/admin_user.rb 11 remove unused methods (AdminUser#find_for_database_authentication) 0e95a03f liwh
    app/models/contact.rb 13 remove unused methods (Contact#read_attribute_for_validation) 995134ee saberma
    app/models/payment.rb 44 remove unused methods (Payment#dualfun?) 07c23fed saberma
    app/models/shop_theme.rb 289 remove unused methods (ShopTheme#config_settings_path) cf023239 saberma
    app/models/order.rb 129 remove unused methods (Order#financial_status_refunded?) 0eca44c8 saberma
    app/models/order.rb 206 remove unused methods (Order#other_orders) e822e262 saberma
    app/models/order.rb 267 remove unused methods (OrderLineItem#fulfillment_created_at) dd2d3e4b saberma
    app/models/order.rb 271 remove unused methods (OrderLineItem#product_deleted) dd2d3e4b saberma
    app/models/customer.rb 65 remove unused methods (Customer#after_token_authentication) 326920c8 liwh
    app/models/customer.rb 91 remove unused methods (Customer#find_for_database_authentication) fe6b89ab saberma
    app/models/user.rb 59 remove unused methods (User#after_token_authentication) d1be03cb saberma
    app/models/user.rb 75 remove unused methods (User#find_for_database_authentication) 36ad8a97 saberma
    app/models/shop.rb 131 remove unused methods (Shop#mobile_theme) f74e5eab saberma
    app/models/shop.rb 151 remove unused methods (Shop#format_money_with_currency) 13f9550a saberma
    app/models/shop.rb 155 remove unused methods (Shop#format_money) 13f9550a saberma
    app/models/shop.rb 159 remove unused methods (Shop#format_money_with_currency_in_emails) 13f9550a saberma
    app/models/session_cart.rb 80 remove unused methods (SessionLineItem#line_weight) 76ddb21b saberma
    app/models/key_values.rb 443 remove unused methods (KeyValues::Collection::Order#is_manual?) a8a6e83d saberma
    app/models/shipping.rb 29 remove unused methods (Shipping#code_name) 81783f74 saberma
    app/controllers/theme/themes_controller.rb 134 remove unused methods (Theme::ThemesController#authenticate_shop!) 66f3a20d saberma
    app/controllers/api/v1/app_controller.rb 23 remove unused methods (Api::V1::AppController#page) df886e0b saberma
    app/controllers/api/v1/app_controller.rb 27 remove unused methods (Api::V1::AppController#per_page) df886e0b saberma
    app/controllers/admin/account_controller.rb 37 remove unused methods (Admin::AccountController#change_plan) 3aa986e6 saberma
    app/controllers/admin/oauth_controller.rb 6 remove unused methods (Admin::OauthController#authorize) 3b30d20f saberma
    app/controllers/admin/oauth_controller.rb 18 remove unused methods (Admin::OauthController#allow) 3b30d20f saberma
    app/controllers/admin/sessions_controller.rb 21 remove unused methods (Admin::SessionsController#after_sign_out_path_for) 124770db liwh
    app/helpers/admin/shops_helper.rb 45 remove unused methods (Admin::ShopsHelper#url_with_protocol) 2d58ee26 liwh
    app/helpers/admin/app_helper.rb 13 remove unused methods (Admin::AppHelper#link_to_delete) 6fe2c33e liwh
    app/helpers/admin/app_helper.rb 72 remove unused methods (Admin::AppHelper#tt) 4abaf771 liwh
    config/initializers/logger.rb 5 remove trailing whitespace fdef5afa saberma