Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

wyrmkill/depot

Edit Repository
Build
8
Branch
master
Commit
d60ab8f
Duration
5 secs
Finished
about 1 year ago
Message
Jacking with stripe
Rebuild

Analyze Result

Warning count: 61

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/controllers/line_items_controller.rb 44 move model logic into model (format use_count > 4) 21cfd060 Tim
    app/views/line_items/_line_item.html.erb 7 law of demeter e809cb0a Tim
    app/views/line_items/_line_item.text.erb 3 law of demeter 91d320c6 Tim
    db/migrate/20120407225602_combine_items_in_cart.rb 14 isolate seed data 198b33f9 Tim
    db/schema.rb 21 always add db index (line_items => [product_id]) 21cfd060 Tim
    db/schema.rb 21 always add db index (line_items => [cart_id]) 21cfd060 Tim
    db/schema.rb 21 always add db index (line_items => [order_id]) 21cfd060 Tim
    app/controllers/orders_controller.rb 18,45,72,88 use before_filter for show,edit,update,destroy 39a66312 Tim
    app/controllers/line_items_controller.rb 17,38,63,79 use before_filter for show,edit,update,destroy 21cfd060 Tim
    app/controllers/products_controller.rb 15,36,56,65,81 use before_filter for show,edit,who_bought,update,destroy ^7677957 Tim
    app/controllers/users_controller.rb 15,36,58,74 use before_filter for show,edit,update,destroy 39241681 Tim
    app/views/orders/_form.html.erb 1 replace instance variable with local variable 39a66312 Tim
    app/views/orders/_form.html.erb 2 replace instance variable with local variable 39a66312 Tim
    app/views/orders/_form.html.erb 4 replace instance variable with local variable a2283ca5 Tim
    app/views/orders/_form.html.erb 9 replace instance variable with local variable 39a66312 Tim
    app/views/line_items/_form.html.erb 1 replace instance variable with local variable 21cfd060 Tim
    app/views/line_items/_form.html.erb 2 replace instance variable with local variable 21cfd060 Tim
    app/views/line_items/_form.html.erb 4 replace instance variable with local variable 21cfd060 Tim
    app/views/line_items/_form.html.erb 7 replace instance variable with local variable 21cfd060 Tim
    app/views/line_items/_line_item.html.erb 1 replace instance variable with local variable e809cb0a Tim
    app/views/products/_form.html.erb 1 replace instance variable with local variable ^7677957 Tim
    app/views/products/_form.html.erb 2 replace instance variable with local variable ^7677957 Tim
    app/views/products/_form.html.erb 4 replace instance variable with local variable ^7677957 Tim
    app/views/products/_form.html.erb 7 replace instance variable with local variable ^7677957 Tim
    app/views/users/_form.html.erb 3 replace instance variable with local variable 39241681 Tim
    app/views/users/_form.html.erb 4 replace instance variable with local variable 39241681 Tim
    app/views/users/_form.html.erb 6 replace instance variable with local variable 39241681 Tim
    app/views/users/_form.html.erb 9 replace instance variable with local variable 39241681 Tim
    app/views/carts/_form.html.erb 1 replace instance variable with local variable 21cfd060 Tim
    app/views/carts/_form.html.erb 2 replace instance variable with local variable 21cfd060 Tim
    app/views/carts/_form.html.erb 4 replace instance variable with local variable 21cfd060 Tim
    app/views/carts/_form.html.erb 7 replace instance variable with local variable 21cfd060 Tim
    app/controllers/application_controller.rb 37 remove unused methods (ApplicationController#default_url_options) a04a95ba Tim
    app/models/line_item.rb 1 protect mass assignment 21cfd060 Tim
    app/models/order.rb 1 protect mass assignment 39a66312 Tim
    app/models/user.rb 1 protect mass assignment 39241681 Tim
    app/models/cart.rb 1 protect mass assignment 21cfd060 Tim
    db/seeds.rb 18 remove trailing whitespace ^7677957 Tim
    app/controllers/orders_controller.rb 35 remove trailing whitespace 39a66312 Tim
    app/controllers/line_items_controller.rb 3 remove trailing whitespace ec8b8f42 Tim
    app/models/order.rb 10 remove tab, use spaces instead 525c5015 Tim
    app/models/user.rb 9 remove tab, use spaces instead ec8b8f42 Tim
    app/models/product.rb 5 remove tab, use spaces instead c2418f74 Tim
    app/models/cart.rb 2 remove tab, use spaces instead 21cfd060 Tim
    app/helpers/application_helper.rb 3 remove tab, use spaces instead e809cb0a Tim
    db/seeds.rb 14 remove tab, use spaces instead ^7677957 Tim
    db/migrate/20120407225602_combine_items_in_cart.rb 4 remove tab, use spaces instead 198b33f9 Tim
    script/load_orders.rb 4 remove tab, use spaces instead 4cd88cb6 Tim
    app/controllers/sessions_controller.rb 7 remove tab, use spaces instead ec8b8f42 Tim
    app/controllers/store_controller.rb 3 remove tab, use spaces instead ec8b8f42 Tim
    app/controllers/application_controller.rb 9 remove tab, use spaces instead 21cfd060 Tim
    app/views/orders/new.html.erb 2 remove tab, use spaces instead 525c5015 Tim
    app/views/store/index.html.erb 9 remove tab, use spaces instead 7908dd1e Tim
    app/views/sessions/new.html.erb 3 remove tab, use spaces instead ec8b8f42 Tim
    app/views/line_items/_line_item.html.erb 6 remove tab, use spaces instead e809cb0a Tim
    app/views/line_items/create.js.erb 8 remove tab, use spaces instead e809cb0a Tim
    app/views/line_items/_line_item.text.erb 2 remove tab, use spaces instead 91d320c6 Tim
    app/views/carts/_cart.html.erb 3 remove tab, use spaces instead 67f740c3 Tim
    app/views/order_notifier/shipped.html.erb 3 remove tab, use spaces instead 68fde356 Tim
    app/views/layouts/application.html.erb 11 remove tab, use spaces instead a04a95ba Tim
    app/views/products/who_bought.atom.builder 2 remove tab, use spaces instead 1473df9a Tim