Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

NYULibraries/marli

Edit Repository
Build
322
Branch
master
Commit
623de6b
Duration
2 secs
Finished
3 days ago
Message
Merge pull request #40 from NYULibraries/feature/update_ruby Updated to ruby 2.3.3 and gems :gem:
Rebuild

Analyze Result

Warning count: 41

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/controllers/users/omniauth_callbacks_controller.rb 5 move model logic into model (@user use_count > 4) 80d13e40 hab278
    app/controllers/users/omniauth_callbacks_controller.rb 81 move model logic into model (address use_count > 4) 5e1b10c9 hab278
    app/controllers/users_controller.rb 80 move model logic into model (@user use_count > 4) 9d267b9d B Alter
    app/controllers/application_controller.rb 28 remove unused methods (ApplicationController#passive_login) 7cd8ab1f B Alter
    app/controllers/application_controller.rb 42 remove unused methods (ApplicationController#after_sign_in_path_for) 7cd8ab1f B Alter
    app/controllers/application_controller.rb 48 remove unused methods (ApplicationController#after_sign_out_path_for) 1143c74a B Alter
    app/controllers/application_controller.rb 73 remove unused methods (ApplicationController#new_session_path) 416d11fd B Alter
    app/helpers/layouts_helper.rb 14 remove unused methods (LayoutsHelper#gauges_tracking_code) 38a3c3c1 Eric Griffis
    app/helpers/layouts_helper.rb 28 remove unused methods (LayoutsHelper#prepend_body) 38a3c3c1 Eric Griffis
    app/helpers/layouts_helper.rb 34 remove unused methods (LayoutsHelper#prepend_yield) 38a3c3c1 Eric Griffis
    app/helpers/layouts_helper.rb 42 remove unused methods (LayoutsHelper#show_tabs) 38a3c3c1 Eric Griffis
    app/controllers/users_controller.rb 80 replace complex creation with factory method (@user attribute_assignment_count > 2) 9d267b9d B Alter
    app/views/application_details/_form.html.erb 1 replace instance variable with local variable ^7fe52ef B Alter
    app/views/application_details/_form.html.erb 2 replace instance variable with local variable 3742b390 Scot Dalton
    app/views/application_details/_form.html.erb 4 replace instance variable with local variable 3742b390 Scot Dalton
    app/views/application_details/_form.html.erb 6 replace instance variable with local variable 3742b390 Scot Dalton
    app/views/application_details/_form.html.erb 13 replace instance variable with local variable 4cdfd64a hab278
    app/views/users/_form.html.erb 1 replace instance variable with local variable 12bb9634 Scot Dalton
    app/views/users/_form.html.erb 2 replace instance variable with local variable 12bb9634 Scot Dalton
    app/views/users/_form.html.erb 4 replace instance variable with local variable 12bb9634 Scot Dalton
    app/views/users/_form.html.erb 6 replace instance variable with local variable 12bb9634 Scot Dalton
    app/views/users/_users.html.erb 25 replace instance variable with local variable 117dd3e3 B Alter
    app/views/users/_users.html.erb 27 replace instance variable with local variable 117dd3e3 B Alter
    app/views/users/_users.html.erb 44 replace instance variable with local variable ^7fe52ef B Alter
    app/views/users/_users.html.erb 63 replace instance variable with local variable 8f7e55b5 B Alter
    app/views/users/_register_form.html.erb 9 replace instance variable with local variable 8ed68842 B Alter
    app/views/users/_register_form.html.erb 15 replace instance variable with local variable f3d77093 Scot Dalton
    app/views/users/_register_form.html.erb 16 replace instance variable with local variable 2b90a149 B Alter
    app/views/users/_register_form.html.erb 18 replace instance variable with local variable 2b90a149 B Alter
    app/views/users/_register_form.html.erb 21 replace instance variable with local variable 2b90a149 B Alter
    app/views/users/_register_form.html.erb 27 replace instance variable with local variable 8ed68842 B Alter
    app/views/users/_register_form.html.erb 52 replace instance variable with local variable 75e109b8 B Alter
    app/views/users/_register_form.html.erb 58 replace instance variable with local variable 75e109b8 B Alter
    app/views/users/_register_form.html.erb 78 replace instance variable with local variable 42970bcd Scot Dalton
    config/routes.rb 3 restrict auto-generated routes application_details (only: [:edit, :update, :index]) e34804d5 Scot Dalton
    config/routes.rb 4 restrict auto-generated routes users (except: [:edit]) e34804d5 Scot Dalton
    app/mailers/registration_mailer.rb 4 use multipart/alternative as content_type of email ^7fe52ef B Alter
    app/mailers/registration_mailer.rb 11 use multipart/alternative as content_type of email a4ee481f Scot Dalton
    db/migrate/20151005201641_change_provider_to_blank_default.rb 5 use query attribute (user.provider?) 55eb4e51 B Alter
    app/views/users/show.html.erb 20 use query attribute (@user.address?) ed2021f9 hab278
    db/migrate/20130111215817_rename_patron_to_user.rb 5 remove trailing whitespace ^7fe52ef B Alter