Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !

alim/msumlst

Edit Repository
Build
188
Branch
strain_search
Commit
1b2fd11
Duration
7 secs
Finished
4 months ago
Message
Strain and/or seqeuence search tests and updates
Rebuild

Analyze Result

Warning count: 28

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    app/views/strains/_show_general.html.erb 60 law of demeter 4fb33fa2 Andy Lim
    app/views/strains/_show_general.html.erb 60 law of demeter 4fb33fa2 Andy Lim
    app/views/clonal_groups/index.html.erb 49 law of demeter b3923a75 Andy Lim
    app/controllers/sequence_types_controller.rb 95 move model logic into model (@sequence_type use_count > 4) b7838369 Andy Lim
    app/controllers/sequence_types_controller.rb 115 move model logic into model (@sequence_type use_count > 4) b7838369 Andy Lim
    app/controllers/accounts_controller.rb 42 move model logic into model (@user use_count > 4) f1ba0470 Andy Lim
    app/controllers/accounts_controller.rb 89 move model logic into model (@account use_count > 4) 5432ff40 Andy Lim
    app/controllers/clonal_groups_controller.rb 87 move model logic into model (@clonal_group use_count > 4) 42e6f44e Andy Lim
    app/controllers/virulences_controller.rb 56 move model logic into model (@virulence use_count > 4) 8a724ee7 Andy Lim
    app/controllers/virulences_controller.rb 82 move model logic into model (@virulence use_count > 4) 8a724ee7 Andy Lim
    app/controllers/users_controller.rb 40 move model logic into model (@users use_count > 4) f1ba0470 Andy Lim
    app/controllers/users_controller.rb 40 move model logic into model (User use_count > 4) f1ba0470 Andy Lim
    app/controllers/strains_controller.rb 126 move model logic into model (@strain use_count > 4) a55e5183 Andy Lim
    app/controllers/strains_controller.rb 148 move model logic into model (@strain use_count > 4) a55e5183 Andy Lim
    app/controllers/application_controller.rb 34 remove unused methods (ApplicationController#after_sign_out_path_for) 06226dc5 Andy Lim
    app/controllers/application_controller.rb 43 remove unused methods (ApplicationController#after_sign_in_path_for) 06226dc5 Andy Lim
    app/controllers/admin_controller.rb 22 remove unused methods (AdminController#password_reset) 19ec5f0c Andy Lim
    app/models/contact.rb 28 remove unused methods (Contact#persisted?) a851927a Andy Lim
    app/models/account.rb 65 remove unused methods (Account#status_str) f1ba0470 Andy Lim
    app/models/strain.rb 133 remove unused methods (Strain#or_seq_search) a96b059e Andy Lim
    app/models/strain.rb 148 remove unused methods (Strain#and_seq_search) 1b2fd11d Andy Lim
    app/views/strains/_strain_list.html.erb 5 replace instance variable with local variable 4fb33fa2 Andy Lim
    app/views/strains/_strain_list.html.erb 6 replace instance variable with local variable 4fb33fa2 Andy Lim
    app/views/strains/_strain_list.html.erb 7 replace instance variable with local variable 4fb33fa2 Andy Lim
    app/views/sequence_types/_sequence_list.html.erb 5 replace instance variable with local variable 4fb33fa2 Andy Lim
    app/views/sequence_types/_sequence_list.html.erb 6 replace instance variable with local variable 4fb33fa2 Andy Lim
    app/views/sequence_types/_sequence_list.html.erb 7 replace instance variable with local variable e1e2caf5 Andy Lim
    app/views/sequence_types/_form.html.erb 33 use query attribute (sequence_type.stec_id?) b3bb86aa Andy Lim