Click here to lend your support to: rails best practices and make a donation at pledgie.com !

Bnei-Baruch/kmedia

Edit Repository
Build
483
Branch
master
Commit
2af19db
Duration
21 secs
Finished
6 months ago
Message
add sha1 to file_assets
Rebuild

Analyze Result

Warning count: 169

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    db/migrate/20120129155236_fill_in_conteiner_types.rb 23 isolate seed data eb59ec2c Edo Shor
    app/views/books/_leaf.html.slim 2 move code into controller 77be73f4 Gregory Shilin
    app/views/kaminari/_paginator.html.erb 14 move code into model (page use_count > 2) 74946d10 Gregory Shilin
    app/controllers/admin/catalogs_controller.rb 11 move model logic into model (@catalogs use_count > 4) 727fab53 Rami Grossman
    app/controllers/admin/api/api_controller.rb 35 move model logic into model (q use_count > 4) 76409c4c amikhile
    app/controllers/admin/api/tokens_controller.rb 5 move model logic into model (@user use_count > 4) 043093b7 Gregory Shilin
    app/controllers/admin/labels_controller.rb 66 move model logic into model (@labels use_count > 4) bba19e23 edoshor
    app/controllers/admin/users_controller.rb 70 move model logic into model (@user use_count > 4) d7b80606 gshilin
    app/controllers/ui_controller.rb 39 move model logic into model (@results use_count > 4) d9fc0583 Gregory Shilin
    config/routes.rb 8 overuse route customizations (customize_count > 3) 2352b374 Gregory Shilin
    config/routes.rb 22 overuse route customizations (customize_count > 3) 0d27735a Gregory Shilin
    config/routes.rb 73 overuse route customizations (customize_count > 3) de55544c Gregory Shilin
    config/routes.rb 96 overuse route customizations (customize_count > 3) acbcb105 Gregory Shilin
    config/routes.rb 110 overuse route customizations (customize_count > 3) 9dc2970e Gregory Shilin
    app/models/virtual_lesson.rb 12 protect mass assignment 6b1fa783 Gregory Shilin
    app/models/server.rb 14 protect mass assignment c4a0349d Rami Grossman
    app/models/comment.rb 14 protect mass assignment c1f11fac Gregory Shilin
    app/models/file_type.rb 10 protect mass assignment 12f3c8a3 Gregory Shilin
    app/models/department.rb 11 protect mass assignment f59da750 Ana Mikhilev
    app/models/container_transcript.rb 14 protect mass assignment 50549e98 Gregory Shilin
    app/models/file_asset_description.rb 13 protect mass assignment cbd73d9a Gregory Shilin
    app/models/lecturer_description.rb 13 protect mass assignment 0d27735a Gregory Shilin
    app/models/lecturer.rb 12 protect mass assignment 727fab53 Rami Grossman
    app/models/content_type.rb 11 protect mass assignment 2a37cae5 Gregory Shilin
    app/models/container_description.rb 16 protect mass assignment 50549e98 Gregory Shilin
    app/models/role.rb 12 protect mass assignment d7b80606 gshilin
    app/models/language.rb 11 protect mass assignment 727fab53 Rami Grossman
    app/models/catalog_description.rb 13 protect mass assignment faad713e gshilin
    app/models/ckeditor/asset.rb 16 protect mass assignment bb0c8b80 Ana Mikhilev
    app/controllers/admin/api/api_controller.rb 35 remove unused methods (Admin::Api::ApiController#file_ids) 76409c4c amikhile
    app/controllers/admin/api/api_controller.rb 167 remove unused methods (Admin::Api::ApiController#get_file_servers) 043093b7 Gregory Shilin
    app/controllers/admin/containers_controller.rb 258 remove unused methods (Admin::ContainersController#get_catalogs_from_matched_description_patterns) 19b852d1 Ana Mikhilev
    app/helpers/home_helper.rb 27 remove unused methods (HomeHelper#button_asset) 96afff2e Gregory Shilin
    app/helpers/search_helper.rb 15 remove unused methods (SearchHelper#creation_date) d9fc0583 Gregory Shilin
    app/helpers/search_helper.rb 23 remove unused methods (SearchHelper#item_includes) d9fc0583 Gregory Shilin
    app/helpers/layout_helper.rb 6 remove unused methods (LayoutHelper#stylesheet) b881db5b Rami Grossman
    app/helpers/layout_helper.rb 10 remove unused methods (LayoutHelper#javascript) b881db5b Rami Grossman
    app/helpers/layout_helper.rb 152 remove unused methods (LayoutHelper#display_catalog_name_by_id) 95584e4c Gregory Shilin
    app/helpers/render_sortable_tree_helper.rb 14 remove unused methods (RenderSortableTreeHelper::Render#render_node) da338ac3 Gregory Shilin
    app/helpers/error_messages_helper.rb 17 remove unused methods (ErrorMessagesHelper::FormBuilderAdditions#error_messages) b881db5b Rami Grossman
    app/models/search.rb 37 remove unused methods (Search#date_type_text) 8144ba81 Gregory Shilin
    app/models/search.rb 199 remove unused methods (Search#search_full_text_files) 44f37d95 amikhile
    app/models/search.rb 225 remove unused methods (Search#set_search_error) d9fc0583 Gregory Shilin
    app/models/virtual_lesson.rb 76 remove unused methods (VirtualLesson#vls_from_date) a8be8add Gregory Shilin
    app/models/virtual_lesson.rb 80 remove unused methods (VirtualLesson#next_position_on) a8be8add Gregory Shilin
    app/models/container.rb 94 remove unused methods (NonemptyValidator#ordered) 50549e98 Gregory Shilin
    app/models/container.rb 108 remove unused methods (NonemptyValidator#not_for_censorship) ec557b00 Gregory Shilin
    app/models/container.rb 160 remove unused methods (NonemptyValidator#to_label) cf2a8bfc Gregory Shilin
    app/models/container.rb 195 remove unused methods (NonemptyValidator#v_containerdate) 50549e98 Gregory Shilin
    app/models/container.rb 412 remove unused methods (NonemptyValidator#parse_container_name) 50549e98 Gregory Shilin
    app/models/file_type.rb 13 remove unused methods (FileType#e2type) 29449091 Gregory Shilin
    app/models/file_asset.rb 40 remove unused methods (FileAsset#v_filedate) 043093b7 Gregory Shilin
    app/models/file_asset.rb 69 remove unused methods (FileAsset#latest_updates) 345725f6 Gregory Shilin
    app/models/file_asset.rb 72 remove unused methods (FileAsset#date_within_range) 50549e98 Gregory Shilin
    app/models/file_asset.rb 82 remove unused methods (FileAsset#typename) 12f3c8a3 Gregory Shilin
    app/models/container_transcript.rb 19 remove unused methods (ContainerTranscript#by_lang) 50549e98 Gregory Shilin
    app/models/lecturer_description.rb 15 remove unused methods (LecturerDescription#by_id_and_language) 50549e98 Gregory Shilin
    app/models/container_description.rb 35 remove unused methods (ContainerDescription#by_lang) 49fec34e Gregory Shilin
    app/models/catalog.rb 150 remove unused methods (ParentValidator#boost_json_admin) 9dc2970e Gregory Shilin
    app/models/catalog.rb 165 remove unused methods (ParentValidator#move_to_child_of) 9dc2970e Gregory Shilin
    app/models/catalog.rb 169 remove unused methods (ParentValidator#move_to_right_of) de040157 Gregory Shilin
    app/models/catalog.rb 174 remove unused methods (ParentValidator#move_to_left_of) de040157 Gregory Shilin
    app/models/ckeditor/attachment_file.rb 24 remove unused methods (Ckeditor::AttachmentFile#url_thumb) 72a404dd Gregory Shilin
    app/models/ckeditor/picture.rb 25 remove unused methods (Ckeditor::Picture#url_content) bb0c8b80 Ana Mikhilev
    app/views/layouts/_admin_navigation.html.haml 12 replace instance variable with local variable a68e82e2 Gregory Shilin
    app/views/admin/file_types/_form.html.haml 1 replace instance variable with local variable fc04e6b0 Gregory Shilin
    app/views/admin/file_types/_form.html.haml 2 replace instance variable with local variable fc04e6b0 Gregory Shilin
    app/views/admin/file_types/_form.html.haml 2 replace instance variable with local variable fc04e6b0 Gregory Shilin
    app/views/admin/file_types/_form.html.haml 14 replace instance variable with local variable fc04e6b0 Gregory Shilin
    app/views/admin/file_types/_form.html.haml 14 replace instance variable with local variable fc04e6b0 Gregory Shilin
    app/views/admin/labels/_form.html.haml 1 replace instance variable with local variable cb6279bc Edo Shor
    app/views/admin/labels/_form.html.haml 1 replace instance variable with local variable cb6279bc Edo Shor
    app/views/admin/labels/_form.html.haml 13 replace instance variable with local variable aec123c5 Edo Shor
    app/views/admin/dictionaries/_form.html.haml 1 replace instance variable with local variable 0db10fc7 Edo Shor
    app/views/admin/dictionaries/_form.html.haml 9 replace instance variable with local variable aec123c5 Edo Shor
    app/views/admin/dictionaries/_form.html.haml 15 replace instance variable with local variable 0afa13bc Edo Shor
    app/views/admin/dictionaries/_form.html.haml 27 replace instance variable with local variable fc347a79 Edo Shor
    app/views/admin/dictionaries/_form.html.haml 30 replace instance variable with local variable cb6279bc Edo Shor
    app/views/admin/dictionaries/_form.html.haml 32 replace instance variable with local variable cb6279bc Edo Shor
    app/views/admin/dictionaries/_form.html.haml 35 replace instance variable with local variable cb6279bc Edo Shor
    app/views/admin/departments/_department_fields.html.haml 1 replace instance variable with local variable f59da750 Ana Mikhilev
    app/views/admin/file_assets/_form.html.haml 1 replace instance variable with local variable 043093b7 Gregory Shilin
    app/views/admin/file_assets/_form.html.haml 3 replace instance variable with local variable 043093b7 Gregory Shilin
    app/views/admin/file_assets/_form.html.haml 12 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/admin/file_assets/_form.html.haml 15 replace instance variable with local variable 2a37cae5 Gregory Shilin
    app/views/admin/file_assets/_form.html.haml 18 replace instance variable with local variable d297dc2a Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 1 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 2 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 2 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 9 replace instance variable with local variable b11da6c1 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 11 replace instance variable with local variable b11da6c1 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 15 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/container_description_patterns/_form.html.haml 15 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/containers/_form_long_descr.html.haml 1 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/containers/_form_long_descr.html.haml 2 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/containers/_form_long_descr.html.haml 6 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 1 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 3 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 11 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 13 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 14 replace instance variable with local variable bd7cd443 Gregory Shilin
    app/views/admin/containers/_form.html.haml 15 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 16 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 26 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 31 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 36 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 41 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 43 replace instance variable with local variable e8a6fb5e Gregory Shilin
    app/views/admin/containers/_form.html.haml 48 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form.html.haml 48 replace instance variable with local variable cff5ca69 Gregory Shilin
    app/views/admin/containers/_form_transcript.html.haml 1 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/containers/_form_transcript.html.haml 2 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/admin/containers/_form_transcript.html.haml 6 replace instance variable with local variable a0706374 Gregory Shilin
    app/views/ui/_last_lesson.html.slim 1 replace instance variable with local variable 89e84202 Gregory Shilin
    app/views/ui/_last_lesson.html.slim 8 replace instance variable with local variable 02ff744c Gregory Shilin
    app/views/ui/_last_lesson.html.slim 38 replace instance variable with local variable 724bd2e2 Gregory Shilin
    app/views/ui/_last_lesson.html.slim 41 replace instance variable with local variable 724bd2e2 Gregory Shilin
    app/views/ui/_last_lesson.html.slim 42 replace instance variable with local variable 07daac3d Gregory Shilin
    app/views/ui/_last_lesson.html.slim 47 replace instance variable with local variable 724bd2e2 Gregory Shilin
    app/views/ui/_last_lesson.html.slim 50 replace instance variable with local variable 724bd2e2 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 2 replace instance variable with local variable 4793daf4 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 4 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 5 replace instance variable with local variable 4793daf4 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 7 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 8 replace instance variable with local variable 4793daf4 Gregory Shilin
    app/views/ui/_homepage_banners.html.slim 10 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_updated_assets.html.slim 16 replace instance variable with local variable 6c625035 Gregory Shilin
    app/views/ui/_updated_assets.html.slim 19 replace instance variable with local variable 6c625035 Gregory Shilin
    app/views/ui/_updated_assets.html.slim 22 replace instance variable with local variable 6c625035 Gregory Shilin
    app/views/ui/_updated_assets.html.slim 27 replace instance variable with local variable 6c625035 Gregory Shilin
    app/views/ui/_show_content.html.slim 4 replace instance variable with local variable a68e82e2 Gregory Shilin
    app/views/ui/_show_content.html.slim 4 replace instance variable with local variable a68e82e2 Gregory Shilin
    app/views/ui/_show_content.html.slim 6 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 7 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 10 replace instance variable with local variable 95584e4c Gregory Shilin
    app/views/ui/_show_content.html.slim 23 replace instance variable with local variable 774e44a9 Gregory Shilin
    app/views/ui/_show_content.html.slim 29 replace instance variable with local variable 936ecc9e Gregory Shilin
    app/views/ui/_show_content.html.slim 72 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_show_content.html.slim 73 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_show_content.html.slim 74 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/ui/_show_content.html.slim 75 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/books/_node.html.slim 5 replace instance variable with local variable 526d1d9a Gregory Shilin
    app/views/common_ui/_sidebar.html.slim 6 replace instance variable with local variable 23ce882f Gregory Shilin
    app/views/common_ui/_sidebar.html.slim 8 replace instance variable with local variable 50549e98 Gregory Shilin
    app/views/common/_navbar.html.slim 26 replace instance variable with local variable f91e4528 Gregory Shilin
    app/views/common/_navbar.html.slim 34 replace instance variable with local variable 46f5f7fc Gregory Shilin
    app/views/common/_navbar.html.slim 34 replace instance variable with local variable 46f5f7fc Gregory Shilin
    app/views/common/_navbar.html.slim 42 replace instance variable with local variable b720c6a7 Gregory Shilin
    app/views/common/_topbanner.html.slim 3 replace instance variable with local variable a9485a8f Gregory Shilin
    app/views/common/_topbanner.html.slim 3 replace instance variable with local variable a9485a8f Gregory Shilin
    app/views/typing/_navbar.html.slim 7 replace instance variable with local variable 0c6dd0cd Gregory Shilin
    app/views/typing/_navbar.html.slim 7 replace instance variable with local variable 0c6dd0cd Gregory Shilin
    app/views/simple/_show_content.html.slim 5 replace instance variable with local variable 1e552920 Gregory Shilin
    app/views/admin/containers/_merge_get_list.html.slim 5 replace instance variable with local variable 67ee11db Gregory Shilin
    app/views/admin/containers/_merge_get_list.html.slim 7 replace instance variable with local variable 67ee11db Gregory Shilin
    config/routes.rb 8 restrict auto-generated routes feeds (only: []) 2352b374 Gregory Shilin
    config/routes.rb 64 restrict auto-generated routes comments (only: []) b720c6a7 Gregory Shilin
    app/controllers/admin/virtual_lessons_controller.rb 39 simplify render in controllers a8be8add Gregory Shilin
    app/views/admin/catalogs/new.html.haml 4 simplify render in views ff31d76e Gregory Shilin
    app/views/admin/catalogs/edit.html.haml 8 simplify render in views ff31d76e Gregory Shilin
    db/migrate/20120129152039_add_content_type_to_container.rb 8 use say with time in migrations 4f8a8bda Gregory Shilin
    db/migrate/20120129155236_fill_in_conteiner_types.rb 11 use say with time in migrations eb59ec2c Edo Shor
    db/migrate/20120129155236_fill_in_conteiner_types.rb 26 use say with time in migrations eb59ec2c Edo Shor
    db/migrate/20120513133127_create_ckeditor_assets.rb 15 remove trailing whitespace bb0c8b80 Ana Mikhilev