Click here to lend your support to: rails best practices and make a donation at pledgie.com !

nbarnes/pixel_paisan

Edit Repository
Build
126
Branch
master
Commit
2200108
Duration
4 secs
Finished
6 months ago
Message
Fix for palettes with zero or one color on editor load
Rebuild

Analyze Result

Warning count: 41

Customize Checks
    Filename Line Number Warning Message Git Commit Git Username
    db/schema.rb 27 always add db index (palettes => [user_id]) a56bf982 nbarnes
    db/schema.rb 38 always add db index (pictures => [palette_id]) a56bf982 nbarnes
    app/views/admin/activities/_admin_picture_thumbnail.html.haml 6 law of demeter fe664076 nbarnes
    app/controllers/pictures_controller.rb 27 move model logic into model (picture use_count > 4) 728a8143 nbarnes
    app/controllers/pictures_controller.rb 57 move model logic into model (@picture use_count > 4) 728a8143 nbarnes
    app/controllers/admin/activities_controller.rb 7 move model logic into model (users_count use_count > 4) 98bafabc nbarnes
    app/controllers/admin/activities_controller.rb 29 move model logic into model (timestamp use_count > 4) fe664076 nbarnes
    app/controllers/galleries_controller.rb 20 remove unused methods (GalleriesController#gallery_params) 0f6a547b nbarnes
    app/controllers/registrations_controller.rb 6 remove unused methods (RegistrationsController#sign_up_params) 5bbb1cd6 nbarnes
    app/controllers/registrations_controller.rb 10 remove unused methods (RegistrationsController#account_update_params) 5bbb1cd6 nbarnes
    app/controllers/pictures_controller.rb 78 remove unused methods (PicturesController#picture_params) 728a8143 nbarnes
    app/controllers/snapshots_controller.rb 21 remove unused methods (SnapshotsController#snapshot_params) 99f95765 NBarnes
    app/controllers/application_controller.rb 14 remove unused methods (ApplicationController#admin_authorize) 7f99031f nbarnes
    app/models/snapshot.rb 12 remove unused methods (Snapshot#created_between) 7f99031f nbarnes
    app/models/user.rb 15 remove unused methods (User#created_between) 7f99031f nbarnes
    app/models/picture.rb 9 remove unused methods (Picture#created_between) 7f99031f nbarnes
    app/controllers/pictures_controller.rb 27 replace complex creation with factory method (picture attribute_assignment_count > 2) 728a8143 nbarnes
    app/views/palettes/_form.html.haml 1 replace instance variable with local variable 2c04f5f7 NBarnes
    app/views/editor/_editor.html.haml 2 replace instance variable with local variable 7b41d3d6 nbarnes
    app/views/editor/_editor.html.haml 2 replace instance variable with local variable 7b41d3d6 nbarnes
    app/views/editor/_palette.html.haml 9 replace instance variable with local variable af746fda nbarnes
    app/views/admin/users/_admin_users_table.html.haml 22 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 23 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 27 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 28 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 32 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 33 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 37 replace instance variable with local variable 68765af5 nbarnes
    app/views/admin/users/_admin_users_table.html.haml 38 replace instance variable with local variable 68765af5 nbarnes
    config/routes.rb 8 restrict auto-generated routes users/palettes (only: []) 70f6ca67 nbarnes
    config/routes.rb 12 restrict auto-generated routes galleries (only: [:show, :index]) 70f6ca67 nbarnes
    app/controllers/pictures_controller.rb 27 use model association (for picture) 728a8143 nbarnes
    app/controllers/pictures_controller.rb 57 use model association (for @picture) 728a8143 nbarnes
    app/controllers/palettes_controller.rb 27 use model association (for @palette) 2c04f5f7 NBarnes
    app/controllers/pictures_controller.rb 21 use scope access 7f99031f nbarnes
    app/controllers/pictures_controller.rb 54 use scope access 7b41d3d6 nbarnes
    app/controllers/pictures_controller.rb 58 use scope access 7f99031f nbarnes
    app/controllers/palettes_controller.rb 38 use scope access 8448bbdc NBarnes
    app/controllers/palettes_controller.rb 51 use scope access 7b41d3d6 nbarnes
    app/controllers/palettes_controller.rb 68 use scope access 7b41d3d6 nbarnes
    app/controllers/snapshots_controller.rb 9 use scope access 6d9497cd nbarnes